-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable arm64/aarch64 wheel builds #3448
Conversation
Move lint steps into its own workflow that can be called from other workflows (`on.workflow_dispatch`).
This allow dependabot to create PR to update thrid-party GitHub Actions.
@nikaro Any idea why uploading takes 1.5 hours (in comparison to building, which takes 20 min)? https://github.com/RaRe-Technologies/gensim/actions/runs/4370071051/jobs/7644594637 |
That's weird, i don't see why the Windows upload takes so much time for seven files when it takes only ~20 minutes for eight files under Ubuntu. And this step did not change 🤔 I wonder if a separate and unique upload job (that would grab the artifacts for all three platforms) wouldn't be more efficient. PS: I see that someone from gensim already opened an issue regarding a similar issue, cf. ogrisel/wheelhouse-uploader#31 |
Might also be simpler to rewrite the upload code using boto3... what do you think? |
Actually, GitHub runners come with AWS CLI installed so it should be even more straightforward to just use In the meantime, i pushed this PR, and it works and has the advantage also to provide the wheels as GitHub artifacts (see at the bottom of the workflow summary page). Replacing |
Migrate wheel build system from multibuild to cibuildwheel to enable builds for ARM64 OSes.
Follow-up of #3430 ping @mpenkov