Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #743: Added exception handling for n_similarity method #882

Closed
wants to merge 5 commits into from
Closed

Fix Issue #743: Added exception handling for n_similarity method #882

wants to merge 5 commits into from

Commits on Sep 25, 2016

  1. Added exception handling for n_similarity method 

    Fix: Word2vec n_similarity returning numpy matrix instead of float with empty list issue #743
in n_similarity() method, if atleast one empty list is passed, it raises ZeroDivisionError.
    @pranay360
    pranay360 authored Sep 25, 2016
    Configuration menu
    Copy the full SHA
    cfae6b5 View commit details
    Browse the repository at this point in the history

  2. Updated n_similarity method, removed assert statement. 

    replace try and catch AssertionError with simple if and else.
    @pranay360
    pranay360 authored Sep 25, 2016
    Configuration menu
    Copy the full SHA
    56743ac View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md

    @pranay360
    pranay360 authored Sep 25, 2016
    Configuration menu
    Copy the full SHA
    1de8f4c View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md

    @pranay360
    pranay360 authored Sep 25, 2016
    Configuration menu
    Copy the full SHA
    ad19f72 View commit details
    Browse the repository at this point in the history

  5. Updated testSimilarities method 

    Added new test cases in testSimilarities method which makes sure whether ZeroDivisionError is raised if atleast one empty list is passed to word2vec.n_similarities method
    @pranay360
    pranay360 authored Sep 25, 2016
    Configuration menu
    Copy the full SHA
    5bc70b6 View commit details
    Browse the repository at this point in the history