Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving issue #908 #942

Closed
wants to merge 4 commits into from
Closed

Resolving issue #908 #942

wants to merge 4 commits into from

Conversation

saksham-s
Copy link

No description provided.

@saksham-s
Copy link
Author

@tmylk pls guide me further as i am quite new to github and have just started on open source.Thanks for the patience.

@tmylk
Copy link
Contributor

tmylk commented Oct 13, 2016

Hi @saksham15082 Welcome and thank you for your contribution.
Please see comments in the identical PR #923
Also @markroxor was thinking of working on it. Please coordinate with him so that there is no duplication of effort.

@saksham-s
Copy link
Author

@markroxor please tell me on what you want to work so that there are no duplications.

@markroxor
Copy link
Contributor

I won't mind taking this one but am involved with other issues as well. Your call @saksham15082 if you would like to take it further. Please go ahead. :)

@piskvorky
Copy link
Owner

@saksham15082 please provide some context and links in the PR description. What is this about?

@tmylk
Copy link
Contributor

tmylk commented Nov 8, 2016

Almost done in #978

@tmylk tmylk closed this Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants