Expand error message to point to alternatives #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, the improved error message seems fine to me. |
jorisvandenbossche
force-pushed
the
expand-msg
branch
from
93c64f9
to
570942b
Compare
pitrou
approved these changes
Nov 13, 2023
|
I noticed that CI isn't run on PRs, so I've filed #4 . Could you merge from main to get it on this PR? |
|
CI is passing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the error message to 1) mention how to still read the file if you know it is trusted, and 2) point users to use ExtensionType instead of PyExtensionType.
(similarly as I did for pandas. Although if you actively installed pyarrow_hotfix, you are probably already aware of it and it's less important to have this expanded message).
@pitrou would you be OK with something like this? (would still need to update the tests that check the message)