Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associate existing subnet GUIDs when configuring director networks #559

Closed
wants to merge 1 commit into from
Closed

Associate existing subnet GUIDs when configuring director networks #559

wants to merge 1 commit into from

Conversation

RageZBla
Copy link

@RageZBla RageZBla commented Sep 4, 2021

Ref #558

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

RageZBla
RageZBla commented Sep 4, 2021
View reviewed changes
api/director_service.go
func (a Api) addGUIDToExistingSubnet(network *Network, existingNetwork *Network) []Subnet {
for k, subnet := range network.Subnets {
for _, existingSubnet := range existingNetwork.Subnets {
if subnet.CIDR == existingSubnet.CIDR {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if the comparison should be made on more fields. In theory it does not really matter since the other field would be updated.

@jaristiz jaristiz mentioned this pull request Sep 8, 2021
Open
markstokan added a commit that referenced this pull request Nov 9, 2022
@markstokan
Create branch with fix for Issue #557
8e5d17c 
* cherry-picking code from forked repo
* #559

Co-authored-by: Mark Stokan <[email protected]>
Co-authored-by: claire tinati <[email protected]>
@wyike
Copy link

wyike commented Nov 17, 2022

In my case, when the az configuration is:

az-configuration:
  - name: AZ1
    iaas_configuration_name: default
    clusters:
      - cluster: os-compute-cluster-1
        drs_rule: MUST
        guid: 5a132e367e2a82348a21
        host_group: null
        resource_pool: PKS
      - cluster: os-compute-cluster-1
        drs_rule: MUST
        guid: d59e16f5431b8beeb615
        host_group: null
        resource_pool: PKSWorkerPool
    guid: 54e4cdfc17edc55ae5d

and will meet error when staging back the director configuration:

cc
{"errors":{"base":["Cannot delete the cluster 'os-compute-cluster-1' in the availability zone 'AZ1' of a deployed product","Cannot have multiple clusters with the same guid. Guid: 5a132e367e2a82348a21"]}}
0

This change doesn't work to fix the problem. But I can use this change to simple fix my problem: https://gitlab.eng.vmware.com/PKS/gear2/-/commit/28838ed57a3edf699ea1e619c0bc45d363df00a2, not sure if you guys can open it.

@xtremerui
Copy link

@dtimm @jaristiz FYI ^^

@ryanhallware
Copy link
Member

Closing due to age. If this is still needed, please resubmit.
-TAS Operability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
unscheduled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RageZBla @cf-gitbot @wyike @xtremerui @ryanhallware