Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post workshop tweaks #26

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Post workshop tweaks #26

wants to merge 2 commits into from

Conversation

Obult
Copy link
Member

@Obult Obult commented Oct 8, 2023

@SirMorfield Some small tweaks, take note on the rounding especially. Since i do not know if this would be the best way to achieve that.
Fixes:

  • removed the if else on response status printing, removes printing success or failure twice
  • rounds the (x, y) coordinate inputs to nearest integer before processing

Oswin Bult added 2 commits October 8, 2023 22:12
The received status message already contains success or failure
@SirMorfield
Copy link
Member

It's better to do the rounding not in converting function.
Because you're implicitly changing the type from a float to a int
So do the rounding here, before the function call.

Nice removing of the if else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants