Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cleaner Messenger + ignore non-handled messages #1753

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

fregante
Copy link
Contributor

Context:

I reorganized the messenger and it seems to work correctly for the existing use cases. I'd like to merge this soon so we can get some testing done.

Based on:

Changes other than reorganizing of the code:

  • Completely ignore non-handled messaged
  • Slightly improve the output of logging

Here you can see some items from the content script:

  • the CS sends MARK_TAB_AS_READY to "runtime" and receives its response (neither one was logged before)
  • the CS receives DETECT_FRAMEWORKS, handles it, and responds
Screen Shot 5

Next:

@twschiller
Copy link
Contributor

image

@twschiller twschiller added this to the 1.4.5 milestone Oct 26, 2021
@fregante
Copy link
Contributor Author

You may merge at your earliest convenience. I just published the same exact version as "stable"

@twschiller twschiller merged commit 68dfcc6 into main Oct 27, 2021
@twschiller twschiller deleted the F/messenger/cleanup branch October 27, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants