-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8347 Fix custom document stylesheets nested stylesheet inheritance #8353
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8353 +/- ##
==========================================
+ Coverage 73.50% 73.53% +0.02%
==========================================
Files 1330 1331 +1
Lines 41142 41172 +30
Branches 7657 7662 +5
==========================================
+ Hits 30241 30275 +34
+ Misses 10901 10897 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! Do we need to include EphemeralFormContent
in these changes also? That one doesn't get nested in document view, but it was using the stylesheets hook to pull in the default/base styles, not sure if that's still needed or not.
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
…8353) * introduce empty sidebarPanelTheme spec file * introduce sidebar theme test * add steps for opening the sidebar * finish failing test with green assertions * replace StylesheetsContext * replace StylesheetsContext provider and hooks usage * fix lint errors and add StylesheetsContext to strictnull * replace ephemeralformcontent logic * fix strict null error
What does this PR do?
<IsolatedComponent>
forDocumentView
,EphemeralFormContent
,CustomFormComponent
#8200Demo
Checklist