-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only retry sandbox postMessage on TimeoutErrors #8822
Only retry sandbox postMessage on TimeoutErrors #8822
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8822 +/- ##
==========================================
- Coverage 74.24% 74.17% -0.08%
==========================================
Files 1332 1332
Lines 40817 40958 +141
Branches 7634 7668 +34
==========================================
+ Hits 30306 30382 +76
- Misses 10511 10576 +65 ☔ View full report in Codecov by Sentry. |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Playwright test resultsDetails Open report ↗︎ Flaky testsedge › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
* add shouldRetry to the pRetry in postSandboxMessage * import TimeoutError to get the error name directly * throw original error if not TimeoutError * use isSpecificError utility
What does this PR do?