Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only retry sandbox postMessage on TimeoutErrors #8822

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Jul 12, 2024

What does this PR do?

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.17%. Comparing base (8318d74) to head (1aeefad).
Report is 62 commits behind head on main.

Files Patch % Lines
src/sandbox/messenger/api.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8822      +/-   ##
==========================================
- Coverage   74.24%   74.17%   -0.08%     
==========================================
  Files        1332     1332              
  Lines       40817    40958     +141     
  Branches     7634     7668      +34     
==========================================
+ Hits        30306    30382      +76     
- Misses      10511    10576      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link

github-actions bot commented Jul 12, 2024

Playwright test results

passed  94 passed
flaky  2 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  100 tests across 33 suites
duration  21 minutes, 7 seconds
commit  1aeefad
info  For more information on how to debug and view this report, see our readme

Flaky tests

edge › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior
chrome › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@mnholtz mnholtz merged commit b08b491 into main Jul 12, 2024
28 checks passed
@mnholtz mnholtz deleted the bugfix/only_retry_sandbox_messages_on_timeouterrors branch July 12, 2024 21:09
grahamlangford pushed a commit that referenced this pull request Jul 12, 2024
* add shouldRetry to the pRetry in postSandboxMessage

* import TimeoutError to get the error name directly

* throw original error if not TimeoutError

* use isSpecificError utility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid JS or JS that throws an error shows a timeout error
3 participants