-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the form state cleanup related to standalone mod component migration #9002
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9002 +/- ##
==========================================
+ Coverage 74.24% 74.37% +0.12%
==========================================
Files 1332 1353 +21
Lines 40817 41898 +1081
Branches 7634 7828 +194
==========================================
+ Hits 30306 31162 +856
- Misses 10511 10736 +225 ☔ View full report in Codecov by Sentry. |
if (activatedModComponent == null) { | ||
// We shouldn't touch "unsaved" form states that do not have a corresponding activated mod component | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This whole concept will be going away soon in an upcoming project phase, when we update the page editor mods list UI and remove the ability to create new standalone mod components in the page editor front end.
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/modLifecycle.spec.ts › create, run, package, and update mod Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but we should include some testing to prevent a regression (Playwright or Jest)
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
For more information on our expectations for the PR process, see the
code review principles doc