#9087 Skip tests for pre-release e2e workflow on msedge/msedge-beta #9126
Conversation
Playwright test results
Details
Flaky testschrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9126 +/- ##
==========================================
+ Coverage 74.24% 74.72% +0.47%
==========================================
Files 1332 1345 +13
Lines 40817 41664 +847
Branches 7634 7766 +132
==========================================
+ Hits 30306 31133 +827
- Misses 10511 10531 +20 ☔ View full report in Codecov by Sentry. |
| @@ -258,6 +263,13 @@ test("Add starter brick to mod", async ({ | |||
| }); | |||
|
|
|||
| await test.step("Add Trigger starter brick to mod", async () => { | |||
| // FIXME: https://github.com/pixiebrix/pixiebrix-extension/issues/9125 | |||
| test.skip( | |||
There was a problem hiding this comment.
nit: we can use test.fixme instead which is functionally the same, but indicates we plan to fix it. Also the fixme comment is redundant - you can include the link in the additional description in the skip/fixme call.
| test.skip( | ||
| process.env.GITHUB_WORKFLOW === PRE_RELEASE_BROWSER_WORKFLOW_NAME && | ||
| isMsEdge(chromiumChannel), | ||
| "Skipping test for MS Edge in pre-release workflow", |
There was a problem hiding this comment.
Is it only failing in the pre-release workflow, but not in PR CI?
There was a problem hiding this comment.
Yeah, based off of inventory of the CI runs in the last week or so. I'm not sure what is going on yet.
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?