Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing for api paths and update playwright documentation #9167

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

fungairino
Copy link
Collaborator

@fungairino fungairino commented Sep 17, 2024

What does this PR do?

  • Better typing for urlPaths
  • Updated documentation for using playwright snapshots

Discussion

@fungairino fungairino self-assigned this Sep 17, 2024
@fungairino fungairino changed the title devex improvements Improve typing for api paths and update playwright documentation Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.79%. Comparing base (8318d74) to head (c761f8e).
Report is 300 commits behind head on main.

Files with missing lines Patch % Lines
src/extensionConsole/pages/mods/Status.tsx 33.33% 2 Missing ⚠️
...c/background/messenger/external/_implementation.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9167      +/-   ##
==========================================
+ Coverage   74.24%   74.79%   +0.54%     
==========================================
  Files        1332     1360      +28     
  Lines       40817    41883    +1066     
  Branches     7634     7822     +188     
==========================================
+ Hits        30306    31326    +1020     
- Misses      10511    10557      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 17, 2024

Playwright test results

passed  126 passed
flaky  2 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  132 tests across 44 suites
duration  12 minutes, 18 seconds
commit  c761f8e
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fungairino fungairino merged commit b85330c into main Sep 18, 2024
23 checks passed
@fungairino fungairino deleted the devex-improvements branch September 18, 2024 18:03
grahamlangford pushed a commit that referenced this pull request Sep 20, 2024
* wip

* better paths type and updated readme

* update types

* fix type error
@grahamlangford grahamlangford added this to the 2.1.2 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants