Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AUTH_WIDGET_* events to lexicon #9204

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Sep 25, 2024

What does this PR do?

Discussion

  • I'm pretty sure "Auth" terminology is legacy. Should we consider changing both the constant and display name prefixes to INTEGRATION_WIDGET_*?

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.78%. Comparing base (8318d74) to head (1e090bc).
Report is 331 commits behind head on main.

Files with missing lines Patch % Lines
src/telemetry/lexicon.ts 0.00% 8 Missing ⚠️
src/components/integrations/AuthWidget.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9204      +/-   ##
==========================================
+ Coverage   74.24%   74.78%   +0.53%     
==========================================
  Files        1332     1367      +35     
  Lines       40817    42187    +1370     
  Branches     7634     7889     +255     
==========================================
+ Hits        30306    31549    +1243     
- Misses      10511    10638     +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 25, 2024

Playwright test results

passed  126 passed
flaky  8 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  13 minutes, 48 seconds
commit  1e090bc
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add new starter brick
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
chrome › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page
chrome › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu
msedge › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu
msedge › tests/smoke/floatingActionButton.spec.ts › sidebar page smoke test › can toggle the sidebar from the floating action button and view the related mod's sidebar panel
chrome › tests/smoke/pageEditor.spec.ts › page editor smoke test › can open the page editor and connect to an open tab

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

github-actions bot commented Oct 2, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@mnholtz mnholtz merged commit 5926ec2 into main Oct 2, 2024
20 checks passed
@mnholtz mnholtz deleted the feature/add_auth_widget_to_lexicon branch October 2, 2024 22:08
@mnholtz mnholtz added this to the 2.1.3 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants