Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9150 Additional sandbox TimeoutError logging and reinjection #9208

Merged
merged 16 commits into from
Oct 2, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Sep 25, 2024

What does this PR do?

  • Part of [Spike] render_nunjucks error spike #9150
  • Introduces SandboxTimeoutError that includes information about the payload size and pending sandbox messages at the time of failure
  • Cache-busts and removes the sandbox from the dom in cases where initial sandbox ping fails. This is to implicitly cause the sandbox to be re-injected on subsequent retries just in case the sandbox failed to load.

@mnholtz mnholtz changed the title Bugfix/9150 sandbox inflight message tally #9150 Additional sandbox TimeoutError logging and reinjection Sep 25, 2024
Copy link

github-actions bot commented Sep 26, 2024

Playwright test results

passed  129 passed
flaky  5 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  13 minutes, 8 seconds
commit  1ef3c6c
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge › tests/extensionConsole/activation.spec.ts › can activate a mod with a database
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
msedge › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 54.71698% with 24 lines in your changes missing coverage. Please review.

Project coverage is 74.79%. Comparing base (8318d74) to head (1ef3c6c).
Report is 329 commits behind head on main.

Files with missing lines Patch % Lines
src/sandbox/messenger/api.ts 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9208      +/-   ##
==========================================
+ Coverage   74.24%   74.79%   +0.54%     
==========================================
  Files        1332     1366      +34     
  Lines       40817    42190    +1373     
  Branches     7634     7887     +253     
==========================================
+ Hits        30306    31555    +1249     
- Misses      10511    10635     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnholtz mnholtz marked this pull request as ready for review October 1, 2024 23:44
Copy link

github-actions bot commented Oct 2, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@mnholtz mnholtz merged commit 810e62b into main Oct 2, 2024
23 checks passed
@mnholtz mnholtz deleted the bugfix/9150_sandbox_inflight_message_tally branch October 2, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants