-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only clear mod component debug logs if logValues is enabled #9225
Conversation
clear: (componentId: UUID) => Promise<void>; | ||
clear: ( | ||
componentId: UUID, | ||
{ logValues }: { logValues: boolean }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could consider renaming this option to something like clearDebugLogs
for clarity
Another consideration is whether to expose this in the protocol interface, or just get the logValues
value in the underlying implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our sync discussion, we're going to keep it as logValues
for consistency. And the implementation doesn't have access to the source for logValues, so we're leaving that to reducePipeline
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9225 +/- ##
==========================================
+ Coverage 74.24% 74.82% +0.57%
==========================================
Files 1332 1367 +35
Lines 40817 42201 +1384
Branches 7634 7891 +257
==========================================
+ Hits 30306 31577 +1271
- Misses 10511 10624 +113 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testschrome-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
Failed to read large IndexedDB value
error #9211Discussion
logValues
only impacts whether we append debug logs to the LOG idb database, so we still need to clear tracesRemaining work
For more information on our expectations for the PR process, see the
code review principles doc