Add support for search parameters in named targets (?id=UUID)
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fregante
commented
Dec 20, 2021
|
|
||
| // Soft warning: Race conditions are possible. | ||
| // This CANNOT be awaited because waiting for it means "I will handle the message." | ||
| // If a message is received before this is ready, it will just have to be ignored. | ||
| let thisTarget: AnyTarget | undefined; | ||
|
|
||
| function compareTargets(to: AnyTarget, thisTarget: AnyTarget): boolean { |
There was a problem hiding this comment.
I looked into using URLPattern to compare the URLs, but unfortunately that API does not care for search parameters because it treats them as a plain string so only exact matches are possible.
This function instead will match the target a.html?id=1 even if the current page is a.html?something=else&id=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably the last piece for this issue, at least for extension pages:
Needs: