[1.0] Various fixes related to spring bone #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default gravityDir was (0.0, 1.0, 0.0) which is against the spec default (0.0, -1.0, 0.0) three-vrm-girlがgravityPowerがあるけどgravityDirがないパターンで（なぜ？）、この影響を受けた
…pace it should apply matrixWorldToCenter to _currentTail
…tead of center space
ke456-png
reviewed
Jul 6, 2022
Comment on lines
-208
to
+210
| this.bone.localToWorld(this._currentTail.copy(this._initialLocalChildPosition)); | ||
| const matrixWorldToCenter = this._getMatrixWorldToCenter(_matA); | ||
| this.bone.localToWorld(this._currentTail.copy(this._initialLocalChildPosition)).applyMatrix4(matrixWorldToCenter); |
There was a problem hiding this comment.
✅ 座標系 : local => world => center
centerはSpringboneの揺れものの中心オブジェクト
Comment on lines
-169
to
+172
| gravityDir: new THREE.Vector3().fromArray(prevSchemaJoint.gravityDir ?? [0.0, 1.0, 0.0]), | ||
| gravityDir: | ||
| prevSchemaJoint.gravityDir != null | ||
| ? new THREE.Vector3().fromArray(prevSchemaJoint.gravityDir) | ||
| : undefined, |
There was a problem hiding this comment.
デフォルト値の設定をここより下流でやっている意図が気になりました。
There was a problem hiding this comment.
どちらでも良いのですが、あえて言えば、Loaderを介さずにSpringBoneを扱う場合向けに VRMSpringBoneJoint 側でデフォルト値がセットされるようになっています。
There was a problem hiding this comment.
Loaderを介さずにSpringBoneを扱う場合向けに VRMSpringBoneJoint 側でデフォルト値がセットされるようになっています。
理解しました。
この実装で良いと思います。
ke456-png
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each commit does different things:
Points need review