-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/examplesをMr.doob's Code Style™で自動整形を行う. #1033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
インデントが崩れる問題がある
ke456-png
commented
Sep 2, 2022
ke456-png
commented
Sep 2, 2022
ke456-png
changed the title
Draft: examples以下だけMr.doob's Code Style™で整形を行う.
/examplesをMr.doob's Code Style™で整形を行う.
Sep 5, 2022
ke456-png
changed the title
/examplesをMr.doob's Code Style™で整形を行う.
/examplesをMr.doob's Code Style™で自動整形を行う.
Sep 5, 2022
主にVSCode ESLint拡張の挙動への対応
lintを実行しpadded-blocksのエラーが出ている箇所を修正
@ke456-png examples下、 lintのルールをオフにするか、あるいはGlitchのときみたいにglobal指定するかでしょうか。 |
no-undef はglobal指定で対応します。 |
0b5vr
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/examplesではMr.doob's Code Style™に従うことになっていますが、自動整形を行うための設定を提供していませんでした。
そのため、ESLintによる自動整形を行うためのパッケージを追加します。
three.jsを参考に以下のパッケージを追加します。
yarn lint
およびyarn lint-fx
はexampleにも適用されるようになります。Issues & Workarounds
HTMLファイルのインラインスクリプトを自動整形する場合、ブロックのインデントが正しくつかない問題があります。
それを回避するためにESLintのpadded-blocksオプションをオフにして自動整形を回避しています。
yarn lint
およびyarn lint-examples
を実行する時に、コマンドライン引数でpadded-blocksオプションを有効にしているためエラーは表示されます。
該当箇所は手動で修正を行ってください。