Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore alpha test workaround #1445

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix: restore alpha test workaround #1445

merged 2 commits into from
Jul 22, 2024

Conversation

yue4u
Copy link
Contributor

@yue4u yue4u commented Jul 22, 2024 •
edited
Loading

@yue4u yue4u changed the base branch from dev to dev-v3 July 22, 2024 06:49
@yue4u yue4u requested a review from ke456-png July 22, 2024 06:58
@ke456-png
Copy link
Contributor

[Memo]
three-vrm v2.0 or later should support Three.js r137 or later

🚨 BREAKING CHANGES
#1232: This drops support of Three.js r136 and prior.
(https://github.com/pixiv/three-vrm/releases/tag/v2.0.0)

ke456-png
ke456-png approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@ke456-png ke456-png left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! 👍

@yue4u yue4u changed the title fix: restore alpha test workaound fix: restore alpha test workaround Jul 22, 2024
@yue4u yue4u merged commit 8d669ae into dev-v3 Jul 22, 2024
6 checks passed
@yue4u yue4u deleted the fix/restore-alpha-test-workaound branch July 22, 2024 08:46
@0b5vr 0b5vr added the bug Something isn't working label Jul 26, 2024
@0b5vr 0b5vr added this to the v3.0.0 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ke456-png ke456-png ke456-png approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yue4u @ke456-png @0b5vr