Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MToon: fix the direction of uv animation #459

Merged
merged 1 commit into from
Jul 28, 2020
Merged

MToon: fix the direction of uv animation #459

merged 1 commit into from
Jul 28, 2020

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Jul 28, 2020

Will resolve #458

The diff explains everything

@0b5vr 0b5vr added the bug Something isn't working label Jul 28, 2020
@0b5vr 0b5vr added this to the next milestone Jul 28, 2020
@0b5vr 0b5vr self-assigned this Jul 28, 2020
@0b5vr
Copy link
Contributor Author

0b5vr commented Jul 28, 2020

We should explicitly define the direction of uv scrolls in the spec of MToon.

Note that the spec of glTF says that the origin of the UV coordinates corresponds to the upper left of a texture image.

Ref: https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#images
Ref: https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/TextureCoordinateTest

Anyway, we are going to follow the implementation in the original MToon for now
(which scrolls backward(?) in s axis, forward(?) in t axis).

@0b5vr 0b5vr merged commit f10623d into dev Jul 28, 2020
@0b5vr 0b5vr deleted the fix-mtoon-uvanimy branch July 28, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MToon: The direction of y-axis uv scroll is opposite
1 participant