Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add cumulative distribution function" #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pizhn
Copy link
Owner

@pizhn pizhn commented Jun 3, 2022

Reverts #13

@pizhn
Copy link
Owner Author

pizhn commented Jun 3, 2022

Well, test failed. Let me look into it

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #14 (0a5e40c) into main (e97c226) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files           3        3           
  Lines         101      101           
=======================================
  Hits           83       83           
  Misses         18       18           
Impacted Files Coverage Δ
src/kde.jl 78.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e159b7e...0a5e40c. Read the comment docs.

@davide-f
Copy link
Contributor

davide-f commented Jul 30, 2022

@noilreed Judging by the previous loc, it may be just a dependency error: Image in testing should be added probably.

Errors encountered while load File{DataFormat{:PNG}, String}("/tmp/jl_KSc05D/inconversion.png").
All errors:
===========================================

ArgumentError: Package ImageIO [82e4d734-157c-48bb-816b-45c225c6df19] is required but does not seem to be installed:
Fatal error:
 - Run `Pkg.instantiate()` to install all recorded dependencies.

===========================================
ArgumentError: Package ImageMagick [6218d12a-5da1-5696-b52f-db25d2ecc6d1] is required but does not seem to be installed:
 - Run `Pkg.instantiate()` to install all recorded dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants