Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate user 65535 #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Eliminate user 65535 #68

wants to merge 1 commit into from

Conversation

asomers
Copy link
Collaborator

@asomers asomers commented Jul 31, 2022

Only two unprivileged users are needed: 65534 and 65533 suffice.

chmod/00.t
This test only needs one unprivileged user.

{mkfifo,open,mkdir,mknod}/00.t
These tests all related to the group ID of a newly created file. They
need two unprivileged users and three groups.

Only two unprivileged users are needed: 65534 and 65533 suffice.

chmod/00.t
This test only needs one unprivileged user.

{mkfifo,open,mkdir,mknod}/00.t
These tests all related to the group ID of a newly created file.  They
need two unprivileged users and three groups.
@asomers asomers requested a review from ngie-eign July 31, 2022 22:30
@asomers
Copy link
Collaborator Author

asomers commented Jul 31, 2022

cc @musikid

Copy link
Collaborator

@ngie-eign ngie-eign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What precipitated this change?
Also, FWIW... it seems like this hardcoded user/group should be parametrized out. If that was done, I'd be more keen with the change.

@asomers
Copy link
Collaborator Author

asomers commented Sep 3, 2022

musikid's GSoC project precipitated this change. For the rewrite we tried to reduce the number of extra users to the minimum, and put them into a config file instead of hard-coding them into each test. The rewrite is nearly done, so I don't intend to keep developing the C/sh version. But I opened this and other PRs as a kind of diff reduction before merging the rewrite. BTW, the new version is at https://github.com/musikid/pjdfstest/tree/master/rust .

asomers added a commit to asomers/pjdfstest that referenced this pull request Feb 5, 2024
If a test case fails and RUST_BACKTRACE is set, print the backtrace of
the point where the test actually failed.

Fixes pjd#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants