Do not normalize an implausible phone.

pjg · Feb 1, 2013 · 1f30058 · 1f30058
1 parent 19c68e7
commit 1f30058
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/phony_rails.rb b/lib/phony_rails.rb
@@ -25,7 +25,7 @@ def self.normalize_number(number, options = {})
       # Add country_number if missing
       number = "#{country_number}#{number}" if not number =~ /^(00|\+)?#{country_number}/
     end
-    number = Phony.normalize(number)
+    number = Phony.normalize(number) if Phony.plausible?(number)
     return number.to_s
   rescue
     number # If all goes wrong .. we still return the original input.

diff --git a/spec/lib/phony_rails_spec.rb b/spec/lib/phony_rails_spec.rb
@@ -34,6 +34,10 @@
       PhonyRails.normalize_number('+31-70-4157134', :country_code => 'NL').should eql('31704157134')
       PhonyRails.normalize_number('0323-2269497', :country_code => 'BE').should eql('323232269497')
     end
+
+    it "should not normalize an implausible number" do
+      PhonyRails.normalize_number('01').should eql('01')
+    end
   end
 
   describe 'defining ActiveRecord#phony_normalized_method' do