Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove errors.Print #23

Merged
merged 1 commit into from
May 10, 2016
Merged

Remove errors.Print #23

merged 1 commit into from
May 10, 2016

Conversation

davecheney
Copy link
Member

errors.Print had a number of problems. Firstly, it was hard coded to
print to os.Stderr, which made it difficult to test, and hard to write
an example test for. Secondly, comments made in issue #20 make it clear
that helpers need to have a high bar for inclusion in this package, and
something that wrapped errors.Fprint in a way that was hard to test
fails that bar.

So, Remove errors.Print, which frees the identifier for being reused
later, and reduces the size of the package.

errors.Print had a number of problems. Firstly, it was hard coded to
print to os.Stderr, which made it difficult to test, and hard to write
an example test for. Secondly, comments made in issue #20 make it clear
that helpers need to have a high bar for inclusion in this package, and
something that wrapped errors.Fprint in a way that was hard to test
fails that bar.

So, Remove errors.Print, which frees the identifier for being reused
later, and reduces the size of the package.
@davecheney davecheney merged commit 01fff4b into master May 10, 2016
@davecheney davecheney deleted the remove-print branch May 10, 2016 01:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant