Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closing file descriptors twice #62

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Fix closing file descriptors twice #62

merged 1 commit into from
Feb 2, 2022

Commits on Jan 28, 2022

  1. Fix closing file descriptors twice 

    Closing the fd's in this code after using them to create new os.File objects results in the fd being closed twice with disastrous results in multi-threaded code.  os.File already arranges for its finalizer to close the fd.

Found via restic tests.
    @gco
    gco committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    8b1bb40 View commit details
    Browse the repository at this point in the history