Detect the need to increase buffer size on TrueNAS SCALE. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we fail to fetch any attr larger than 1 KB. Motivation: enable restic to back up Mac resource forks on NAS volumes. Currently, it loses data with only an easy-to-miss stderr message.
kuba--
approved these changes
Jul 21, 2024
|
Thank you so much for the swift review! |
tomponline
referenced
this pull request
in canonical/lxd
Jul 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/pkg/xattr](https://togithub.com/pkg/xattr) | `v0.4.9` -> `v0.4.10` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pkg/xattr (github.com/pkg/xattr)</summary> ### [`v0.4.10`](https://togithub.com/pkg/xattr/releases/tag/v0.4.10) [Compare Source](https://togithub.com/pkg/xattr/compare/v0.4.9...v0.4.10) #### What's Changed - Fix FIFO handling on Solaris by [@​greatroar](https://togithub.com/greatroar) in [https://github.com/pkg/xattr/pull/70](https://togithub.com/pkg/xattr/pull/70) - Add support for go 1.21 by [@​kuba--](https://togithub.com/kuba--) in [https://github.com/pkg/xattr/pull/72](https://togithub.com/pkg/xattr/pull/72) - Detect the need to increase buffer size on TrueNAS SCALE. by [@​erikrose](https://togithub.com/erikrose) in [https://github.com/pkg/xattr/pull/73](https://togithub.com/pkg/xattr/pull/73) #### New Contributors - [@​erikrose](https://togithub.com/erikrose) made their first contribution in [https://github.com/pkg/xattr/pull/73](https://togithub.com/pkg/xattr/pull/73) **Full Changelog**: pkg/xattr@v0.4.9...v0.4.10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/lxd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we fail to fetch any attr larger than 1 KB.
Motivation: enable restic to back up Mac resource forks on NAS volumes. Currently, it loses data with only an easy-to-miss stderr message.
Unfortunately, TrueNAS doesn't document this difference anywhere, if indeed it's their fault, but it's empirically what happens. This is on an OpenZFS volume with the
xattr=saproperty.Thanks!