Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ziglang.org #73

Merged
merged 2 commits into from
Mar 13, 2023
Merged

+ziglang.org #73

merged 2 commits into from
Mar 13, 2023

Conversation

jhheider
Copy link
Contributor

@jhheider jhheider commented Dec 8, 2022

doesn't currently build on linux/x86-64:gha:debian:buster-slim due to OOM. The Zig team is well aware that their build process is memory-heavy: ziglang/zig#6485

@jhheider jhheider requested a review from mxcl December 8, 2022 23:45
@what-the-diff
Copy link

what-the-diff bot commented Dec 8, 2022

  • The build.zig file was modified to include the headerpad_max_install_names option
  • A package yml file was added for ziglang/zig, which includes a patch that applies the same change as in 1 above

@jhheider jhheider force-pushed the +ziglang.org branch 6 times, most recently from 1af6528 to 51979eb Compare December 9, 2022 17:34
@jhheider jhheider marked this pull request as draft December 9, 2022 17:36
@jhheider jhheider removed the request for review from mxcl December 9, 2022 17:36
@mxcl
Copy link
Member

mxcl commented Dec 23, 2022

We need self-hosted x86 clearly

@jhheider jhheider force-pushed the +ziglang.org branch 2 times, most recently from e17db6c to 415e610 Compare January 7, 2023 00:56
@jhheider jhheider force-pushed the +ziglang.org branch 4 times, most recently from bca4573 to 19dca48 Compare January 17, 2023 01:14
@jhheider
Copy link
Contributor Author

@mxcl do you have any familiarity with this: https://github.com/teaxyz/pantry.extra/actions/runs/3935162447/jobs/6730616244

+ codesign -v --sign - --force --preserve-metadata=entitlements,requirements,flags,runtime /opt/ziglang.org/v0.10.0/bin/zig
/Library/Developer/CommandLineTools/usr/bin/codesign_allocate: fatal error: file not in an order that can be processed (function starts data out of place): /opt/ziglang.org/v0.10.0/bin/zig
/opt/ziglang.org/v0.10.0/bin/zig: the codesign_allocate helper tool cannot be found or used

Only occurs on darwin/x86-64 (I'm manually running codesign to see the actual error, since ruby-machos doesn't pass it out).

@mxcl
Copy link
Member

mxcl commented Jan 17, 2023

who's doing the code signing? (looks like zig is, but not sure since the + prefixes suggest we might be).

If us, can we skip it?

@jhheider
Copy link
Contributor Author

who's doing the code signing? (looks like zig is, but not sure since the + prefixes suggest we might be).

If us, can we skip it?

It's us in fix-machos.rb. I added a manual invocation using the same command line to see what the actual error is. I think we'd need to make a specific exemption in fix-machos.rb, but that's not impossible.

@mxcl
Copy link
Member

mxcl commented Jan 18, 2023

maybe this brew patch? https://github.com/Homebrew/homebrew-core/blob/master/Formula/zig.rb#L80

headerpad is a thing that code signing needs sometimes.

@jhheider
Copy link
Contributor Author

Already present. ziglang/zig#9565 is interesting, but doesn't make me closer to understanding.

@jhheider jhheider force-pushed the +ziglang.org branch 2 times, most recently from f12e3d7 to 1dc24bd Compare January 19, 2023 03:21
@jhheider
Copy link
Contributor Author

otool outputs, in case that helps anyone: https://gist.github.com/jhheider/ab79a6b55fae8231b734188a789684cc

@jhheider jhheider force-pushed the +ziglang.org branch 2 times, most recently from 7b06f31 to d16e3bf Compare February 18, 2023 02:16
@lino-levan
Copy link
Contributor

Given that tea now allows packages that only build on Mac OS, is there anything that could be done to push this forward?

@jhheider
Copy link
Contributor Author

A better solution is probably to what Max originally suggested and use vendored packages, a la https://github.com/teaxyz/pantry.extra/blob/main/projects/bun.sh/package.yml. I'll see if I can't whip that up.

@jhheider jhheider marked this pull request as ready for review March 13, 2023 23:45
@jhheider
Copy link
Contributor Author

closes #609

@jhheider jhheider merged commit 80afd88 into main Mar 13, 2023
@jhheider jhheider deleted the +ziglang.org branch March 13, 2023 23:46
@jhheider
Copy link
Contributor Author

for you, @lino-levan

@lino-levan
Copy link
Contributor

Thanks!

@lino-levan lino-levan mentioned this pull request Mar 13, 2023
mxcl added a commit that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants