Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Change regex/iregex to use re.search instead of re.match #1358

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Feb 5, 2024

Description

Change fetchItem's regex and iregex filters to use re.search rather re.match.

This means that the pattern is now matched from anywhere the string, not start of the string:

The user can specify ^ in their regex if they want to continue to match the start of the string.

See:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

plexapi/base.py Outdated Show resolved Hide resolved
Co-authored-by: JonnyWong16 <[email protected]>
@JonnyWong16 JonnyWong16 merged commit 7c99d4a into pkkid:master Feb 17, 2024
5 checks passed
@glensc glensc deleted the filter-search branch February 18, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants