Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set media and part indexes when generating stream url #1428

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

montaguethomas
Copy link
Contributor

Description

Resolve bug where download() on objects with multiple media/parts end up generating the same transcode urls to download.

Fixes #1427

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 merged commit f1c3d3a into pkkid:master Jun 22, 2024
5 checks passed
@montaguethomas montaguethomas deleted the patch-1 branch July 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download() with kwargs clobbers multiple parts/media
2 participants