Prevent override of gmap gestureHandling setting #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plainheart
approved these changes
Sep 17, 2024
|
Thank you! I will release a new version for this change later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
This pr adds the smalles possible change to fix #19, allowing to use the google maps
gestureHandlingsetting in the extension configuration object. I've tested the proposed changes with my application.It also shouldn't break existing behaviour as shown in the following table (3 behaviour changes marked bold):
roamgestureHandlingHappy to receive your review @plainheart 😊
And btw, thanks for the great extension! 🙌