minor: clear output directory before writing gtfs #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clear /tmp/gtfs before running OutputGTFSCommand - Log errors from running zip command
|
The problem also prevents me to run multiple instances of dtd2mysql against multiple databases at the same time on the same agent as part of a build pipeline. I will ned to use a unique temp dir to prevent this problem. |
|
yeah, I think that would be a better solution that clearing the tmp dir |
|
I will make a pull request soon after confirming my fork runs without problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use a fork of this code that writes extra files to the gtfs zip and then switch back to a version that doesn't write them the extra files will be in any subsequent zips you generate until the OS clears the temp dir.
The "right" way to fix this is probably to use a unique temp dir on every run but I think that could be a breaking change.