Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some "tweet created" events are stuck in the queue #51

Closed
1 of 2 tasks
boreq opened this issue Nov 14, 2023 · 1 comment · Fixed by #68
Closed
1 of 2 tasks

Some "tweet created" events are stuck in the queue #51

boreq opened this issue Nov 14, 2023 · 1 comment · Fixed by #68
Assignees

Comments

@boreq
Copy link
Contributor

boreq commented Nov 14, 2023

It looks like tweets for some notes will simply never be posted. Some of them can't be posted presumably because users revoked permissions for the app, some can't be posted because Twitter keeps replying with "too many requests" for some unknown reason.

I think if a note for which a tweet can't be posted becomes older than e.g. 7 days we should no longer try to post that tweet and drop it from the queue. Firstly with an overwhelming likelihood we will never actually manage to post it so what is the point in trying over and over again. Secondly after some time it may actually be undesirable to suddenly have old notes posted to your profile as they are no longer relevant and it will be confusing to the user.

Checklist:

@boreq boreq added bug Something isn't working unfortunate and removed bug Something isn't working labels Nov 14, 2023
@boreq boreq self-assigned this Nov 17, 2023
@boreq
Copy link
Contributor Author

boreq commented Nov 17, 2023

On 2023-11-17 we merged #63. After 2023-11-25 we can remove the code which supports old events with missing data in them after confirming that the queue length has dropped to zero at least temporarily.

@boreq boreq linked a pull request Nov 29, 2023 that will close this issue
@boreq boreq closed this as completed in #68 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant