Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old events after some time #63

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Drop old events after some time #63

merged 1 commit into from
Nov 17, 2023

Conversation

boreq
Copy link
Contributor

@boreq boreq commented Nov 17, 2023

The matter of the fact is that some events are stuck in the queue and we just can't post tweets for them. As discussed earlier this may be because someone revoked permissions for our app or somehow ran out of their personal API limit - the exact reason is unclear and doesn't really matter.

This commit removes events which are stuck in the queue after some time.

The reasoning for this is twofold. Firstly the likelihood of actually successfuly posting a tweet which is stuck is very low. As far as I can tell they are just stuck. Secondly posting tweets for notes which are old can be confusing and I'd personally be surprised if I suddently had tweets for notes that are weeks old posted in my profile.

This rollout has to happen in two stages. First we start emitting tweet created events containing new data (nostr events). After a week passes we drop all tweet created events that don't have nostr events in them and change the code to no longer support tweet created events with missing nostr events.

The matter of the fact is that some events are stuck in the queue and we
just can't post tweets for them. As discussed earlier this may be
because someone revoked permissions for our app or somehow ran out of
their personal API limit - the exact reason is unclear and doesn't
really matter.

This commit removes events which are stuck in the queue after some time.

The reasoning for this is twofold. Firstly the likelihood of actually
successfuly posting a tweet which is stuck is very low. As far as I can
tell they are just stuck. Secondly posting tweets for notes which are
old can be confusing and I'd personally be surprised if I suddently had
tweets for notes that are weeks old posted in my profile.

This rollout has to happen in two stages. First we start emitting tweet
created events containing new data (nostr events). After a week passes
we drop all tweet created events that don't have nostr events in them
and change the code to no longer support tweet created events with
missing nostr events.
@boreq boreq merged commit ca1a0f8 into main Nov 17, 2023
2 checks passed
@boreq boreq deleted the drop-old-events branch November 17, 2023 08:26
@boreq boreq self-assigned this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant