Fix some warnings #1274
Merged
Fix some warnings #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello @mplorentz |
mplorentz
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Hi @RomanPodymov, thanks so much for the contribution. I'm sorry it's take so long to get back to you, we aren't working much on Planetary anymore.
I think you can ignore the test failures for these tests:
FeedStrategyTests.testPostsAlgorithm()
FeedStrategyTests.testPostsAndContactsAlgorithm()
FeedStrategyTests.testRecentlyActivePostsAndContactsAlgorithm()
They are also failing on main. However I am worried about this failing test:
AppConfigurationTests.test_archiving()
As that one has not failed on main, and I suspect it may be related to the changes to AppConfiguration+Data.swift. If you could take a look into that I would appreciate it. Otherwise I will look into it when I get time.
|
Hello @mplorentz |
mplorentz
added
the
Skip-Changelog
mplorentz
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Thank you for planetary-ios.
Fix some warnings.