-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing new.py, lots of other minor fixes, and lots of tests. #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be imported by a user without multidict being installed.
…_class arguments to their constructors.
…mps() here, but we do.
…xception and error message.
… otherwise eliminated some un-called code.
…ually returns floats instead of sometimes ints, and some documentation fixed.
…pdated PlanetaryPy link and some alt text.
… otherwise get ImportError, even though not required for normal install.
…t conversion, otherwise python38 correctly complains about a race condition.
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
===========================================
+ Coverage 79.85% 94.84% +14.99%
===========================================
Files 12 12
Lines 1911 1922 +11
===========================================
+ Hits 1526 1823 +297
+ Misses 385 99 -286
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pvl.new
without multidict being available, will now properly yield an ImportError.dump()
anddumps()
functions now properly overwritten inpvl.new
.char_allowed()
function in grammar objects now raises a more useful ValueError than just a generic Exception.collections.PVLMultiDict
wasn't correctly inserting Mapping objects with theinsert_before()
andinsert_after()
methods.token.Token
class's__index__()
function didn't always properly return an index.token.Token
class's__float__()
function would return int objects if the token could be converted to int. Now always returns floats.Related Issue
Would close #89
How Has This Been Tested?
Types of changes
Checklist:
Licensing:
This project is released under the LICENSE.