Release MacOS with CGO enabled #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatih
approved these changes
Jun 29, 2022
dbussink
force-pushed
the
dbussink/release-macos-cgo-enabled
branch
from
e93695b
to
13699bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
goreleaserusage to use https://github.com/goreleaser/goreleaser-cross which provides a cross compilation toolchain so we can enable CGO for the MacOS binary.planetscale/discussion#181 talks more about the issue this helps with which was also reported upstream in golang/go#52839 and I suspect golang/go#43398 is also very related.
We can work around this by building with
CGO_ENABLED=1but we do need a cross compilation setup which https://github.com/goreleaser/goreleaser-cross provides.