Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Vtadmin test flakiness #278

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Reduce Vtadmin test flakiness #278

merged 3 commits into from
Jul 7, 2022

Conversation

GuptaManan100
Copy link
Collaborator

@GuptaManan100 GuptaManan100 commented Jul 5, 2022 •
edited
Loading

Description

This PR tries to reduce the VTAdmin end-to-end test flakiness. It follows a two-pronged approach to achieve the goal -

  1. Add a wait time using the virtual-time-budget flag. This makes the requests more consistent but doesn't remove the flakiness entirely.
  2. We also allow retries in the vtadmin web checks so that even if 1 of them succeeds in loading the page, we consider it to be okay.

@GuptaManan100 GuptaManan100 mentioned this pull request Jul 6, 2022
Merged
@frouioui frouioui merged commit b1e089d into main Jul 7, 2022
@frouioui frouioui deleted the vtadmin-flakiness branch July 7, 2022 11:02
@frouioui frouioui mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuptaManan100 @frouioui