VTop corresponding changes for VTAdmin docker image changes to use Nginx #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of using nginx instead of serve node module Signed-off-by: Manan Gupta <[email protected]>
|
The tests will fail until the PR vitessio/vitess#11076 is merged which addresses some issues in the docker file |
This was referenced Aug 23, 2022
Verolop
approved these changes
Aug 23, 2022
|
vitessio/vitess#11076 is merged and the new image is available on docker-hub. The tests also pass now 💕. Merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vitessio/vitess#10770 changed the VTAdmin docker image to use
nginxinstead of theservepackage.The corresponding VTop changes have been made in this PR. The way we deploy
vtadmin-apiremains unchanged. There are just a few changes in thevtadmin-webportion, changing the invoked command, environment variables, and directory for config.