Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upgrade of minor MySQL version #361

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Support upgrade of minor MySQL version #361

merged 8 commits into from
Feb 2, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Jan 18, 2023

This PR adds the code that supports upgrade of minor MySQL versions. The operator runs set global innodb_fast_shutdown = 0 in the mysqld container before it shutdown to enable proper upgrade.

Additionally, replica tablets are the first ones to be rolled out, followed by the primary.

Signed-off-by: Florent Poinsard <[email protected]>

fix debug logging

Signed-off-by: Florent Poinsard <[email protected]>

add the mysql command in prestop

Signed-off-by: Florent Poinsard <[email protected]>

remove un required if

Signed-off-by: Florent Poinsard <[email protected]>

always return the mysqld lifecycle

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>

set label always unless the docker image label could not be parsed

Signed-off-by: Florent Poinsard <[email protected]>

revert change

Signed-off-by: Florent Poinsard <[email protected]>

add pod labels

Signed-off-by: Florent Poinsard <[email protected]>

do not use prestop if no new mysql version is found

Signed-off-by: Florent Poinsard <[email protected]>

do not add label

Signed-off-by: Florent Poinsard <[email protected]>

simplify lifecycle function

Signed-off-by: Florent Poinsard <[email protected]>

remove label

Signed-off-by: Florent Poinsard <[email protected]>

use annotations

Signed-off-by: Florent Poinsard <[email protected]>

remove annotations

Signed-off-by: Florent Poinsard <[email protected]>

use annotations

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui changed the title Support Upgrade/Downgrade of MySQL versions Support upgrade of MySQL version Feb 2, 2023
@frouioui frouioui changed the title Support upgrade of MySQL version Support upgrade of minor MySQL version Feb 2, 2023
Copy link
Collaborator

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to use obj.SetAnnotations for storing if a pod has gone through a MySQL version upgrade or not

pkg/operator/vttablet/pod.go Outdated Show resolved Hide resolved
pkg/apis/planetscale/v2/labels.go Outdated Show resolved Hide resolved
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui marked this pull request as ready for review February 2, 2023 17:08
@frouioui frouioui merged commit ef216d5 into main Feb 2, 2023
@frouioui frouioui deleted the new-mysql-default branch February 2, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants