-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support upgrade of minor MySQL version #361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
force-pushed
the
new-mysql-default
branch
2 times, most recently
from
January 26, 2023 19:41
225ffe5
to
de22505
Compare
35 tasks
frouioui
force-pushed
the
new-mysql-default
branch
from
February 1, 2023 13:20
fa7c715
to
51186b4
Compare
Signed-off-by: Florent Poinsard <[email protected]> fix debug logging Signed-off-by: Florent Poinsard <[email protected]> add the mysql command in prestop Signed-off-by: Florent Poinsard <[email protected]> remove un required if Signed-off-by: Florent Poinsard <[email protected]> always return the mysqld lifecycle Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]> set label always unless the docker image label could not be parsed Signed-off-by: Florent Poinsard <[email protected]> revert change Signed-off-by: Florent Poinsard <[email protected]> add pod labels Signed-off-by: Florent Poinsard <[email protected]> do not use prestop if no new mysql version is found Signed-off-by: Florent Poinsard <[email protected]> do not add label Signed-off-by: Florent Poinsard <[email protected]> simplify lifecycle function Signed-off-by: Florent Poinsard <[email protected]> remove label Signed-off-by: Florent Poinsard <[email protected]> use annotations Signed-off-by: Florent Poinsard <[email protected]> remove annotations Signed-off-by: Florent Poinsard <[email protected]> use annotations Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
new-mysql-default
branch
from
February 2, 2023 10:18
17fc638
to
7fd287a
Compare
frouioui
changed the title
Support Upgrade/Downgrade of MySQL versions
Support upgrade of MySQL version
Feb 2, 2023
frouioui
changed the title
Support upgrade of MySQL version
Support upgrade of minor MySQL version
Feb 2, 2023
Signed-off-by: Florent Poinsard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be able to use obj.SetAnnotations
for storing if a pod has gone through a MySQL version upgrade or not
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
new-mysql-default
branch
from
February 2, 2023 15:14
19b6d14
to
6e9dfb1
Compare
GuptaManan100
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the code that supports upgrade of minor MySQL versions. The operator runs
set global innodb_fast_shutdown = 0
in the mysqld container before it shutdown to enable proper upgrade.Additionally, replica tablets are the first ones to be rolled out, followed by the primary.