Support safe MySQL upgrades #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuptaManan100
approved these changes
Oct 5, 2023
Comment on lines
47
to
58
| { | ||
| name: "equal version with same registry", | ||
| current: "docker.io/vitess/mysql:8.0.23", | ||
| desired: "docker.io/vitess/mysql:8.0.23", | ||
| needsSafe: false, | ||
| }, | ||
| { | ||
| name: "equal version with different registry", | ||
| current: "docker.io/vitess/mysql:8.0.23", | ||
| desired: "docker.io/vitess/mysql:8.0.23", | ||
| needsSafe: false, | ||
| }, |
There was a problem hiding this comment.
They are the same cases
deepthi
approved these changes
Oct 5, 2023
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
support-mysql-upgrade
branch
from
4628963
to
af29fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds code logic that will set the
global.innodb_fast_shutdownMySQL variable to0if there is a need for a safe MySQL upgrade.Part of vitessio/vitess#14160