Add mysqld exporter resources spec #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapsuk
force-pushed
the
mysqld-exporter-resources
branch
from
1208eb7
to
13c320d
Compare
Signed-off-by: Maxim Krasilnikov <[email protected]>
chapsuk
force-pushed
the
mysqld-exporter-resources
branch
from
13c320d
to
0770a9e
Compare
frouioui
approved these changes
Jan 3, 2024
|
Closing this PR and re-opening it to trigger the CI jobs that are in |
GuptaManan100
approved these changes
Jan 4, 2024
|
Thank-you @chapsuk for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysql exporter container has fixed resources settings, it would be great to have option to redefine resources for this container
https://github.com/planetscale/vitess-operator/blob/main/pkg/operator/vttablet/pod.go#L230-L235