Add support for customizing terminationGracePeriodSeconds of the VTTablet pods #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blet pods Signed-off-by: Yohei Yoshimuta <[email protected]>
mattlord
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Thanks, @yoheimuta ! I just had one nit about the existing var name. Let me know what you think.
pkg/operator/vttablet/pod.go
Outdated
| if spec.Vttablet.TerminationGracePeriodSeconds != nil { | ||
| obj.Spec.TerminationGracePeriodSeconds = spec.Vttablet.TerminationGracePeriodSeconds | ||
| } else { | ||
| obj.Spec.TerminationGracePeriodSeconds = pointer.Int64Ptr(terminationGracePeriodSeconds) |
There was a problem hiding this comment.
Nit, but I feel like we should rename this variable to defaultTerminationGracePeriodSeconds now.
Signed-off-by: Yohei Yoshimuta <[email protected]>
frouioui
approved these changes
Jan 3, 2024
|
Closing and re-opening to re-trigger the CI tests that are in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for customizing the terminationGracePeriodSeconds of the VTTablet pods. Currently, this value is set to 30 minutes.
Having a fairly high terminationGracePeriodSeconds can lead to issues when adding sidecars that don't handle SIGTERM properly, resulting in long delays during the termination process. At least, this default constant value is not suitable for the use case of unmanaged tablets.
Similar to #406.