Detect mysql_server_version from the mysqld Docker Image
#521
Conversation
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
changed the title
mysql_server_version from the mysqld Docker Image
go.mod
Outdated
| @@ -21,11 +21,11 @@ require ( | |||
| sigs.k8s.io/controller-runtime v0.16.3 | |||
| sigs.k8s.io/controller-tools v0.11.3 | |||
| sigs.k8s.io/kustomize v2.0.3+incompatible | |||
| vitess.io/vitess v0.10.3-0.20240112195828-c53420174d46 | |||
| vitess.io/vitess v0.10.3-0.20240118194106-4c36f2aa6469 | |||
There was a problem hiding this comment.
I upgraded the vitess dependency in order to benefit from the latest changes brought by vitessio/vitess#14988
| var mysqldImage string | ||
| if len(vts.Items) > 0 { | ||
| mysqldImage = vts.Items[0].Spec.Images.Mysqld.Image() | ||
| } | ||
|
|
There was a problem hiding this comment.
Leaving mysqldImage empty and not erroring out if no shard was found is okay, it will just result in using the default mysql server version
| func DockerImageSafeUpgrade(currentVersionImage, desiredVersionImage string) (bool, error) { | ||
| if currentVersionImage == "" || desiredVersionImage == "" { | ||
| // No action if we have unknown versions. |
There was a problem hiding this comment.
Decided to move this from pkg/controller/vitessshardreplication/reconcile_drain.go to this new package to ease readability, no change were applied to DockerImageSafeUpgrade besides renaming the function from safeMysqldUpgrade to this
| @@ -81,7 +81,7 @@ func (r *reconcileHandler) tsInit(ctx context.Context) error { | |||
| } | |||
| // Wrangler wraps the necessary clients and implements | |||
| // multi-step Vitess cluster management workflows. | |||
| wr := wrangler.New(logutil.NewConsoleLogger(), r.ts.Server, r.tmc, collationEnv, parser) | |||
| wr := wrangler.New(logutil.NewConsoleLogger(), r.ts.Server, r.tmc, collationEnv, parser, environment.MySQLServerVersion) | |||
There was a problem hiding this comment.
This change and other changes made to the few wrangler.New function calls we have is not directly related to this PR's enhancement. It was a result of the recent vitess golang dependency upgrade made in this PR.
Description
This PR adds logic that detects what the wanted MySQL server version is according to the image the end user has applied on the mysqld field of their yaml file.
The tag (for example:
mysql:8.0.34) of the image will be parsed and will give us themysql_server_version, this value will then be used to initiate/update all of our pods with the proper--mysql_server_versionflag. If the tag cannot be parsed (if for instance we usemysql:latest) then the defaultmysql_server_versionwill be used internally in the operator (as it is today), and no--mysql_server_versionflag will be set on the Vitess components, resulting in using the default value defined in the Vitess codebase.Testing
We apply a yaml file that uses an official MySQL image, or even our own Vitess'
mysqlimage like so:Or:
When applying the yaml file, the vitess-operator will detect the mysql server version using the image's tag and will eventually add the
--mysql_server_versionflag with the proper value to all components that are using it. After applying the yaml file described above, here is what we get when doingkubectl describe pod:If the label of the docker image was not readable or was simply missing, then no flag is applied and the flag disappears from the list of arguments for each binaries. For instance using
mysql:latestwill result in vitess-operator not knowing what the actual mysql server version is and falling back on using Vitess' default value.