Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Act 3 Quest Import & Misc Changes #30

Merged
merged 43 commits into from
Mar 11, 2024

Conversation

asmoranomar
Copy link
Contributor

@asmoranomar asmoranomar commented Feb 14, 2024

  • Imported all of Act 3's quests.
  • Minor edits to items
  • Started a review process, as some things were missing or unorganized
  • Leverage comments to help guide creation
  • Many other changes

A preview of changes (without the embedded comments) can be seen here

@plasticmacaroni
Copy link
Owner

These changes are much appreciated, and looking amazing. No issue with any changes at all thus far.

@plasticmacaroni
Copy link
Owner

If you're comfortable with the state of the Act 3 content, I can give them a last test, look through all the changes, and squash and merge!

@asmoranomar
Copy link
Contributor Author

Patch 6 has broken all (well most) of my (unmodded) saves. I can't really contribute more until they push a fix.

Non-hostile method to obtain Duke Ravengard's Longsword
Better method to obtain Emblazoned Plate of the Marshal and Duke Ravengard's Longsword
Added OpenFold and CloseFold functionality for style editors
@asmoranomar
Copy link
Contributor Author

I've added some additional functionality for the guide using comments. If you use an editor that is able to leverage language styles, such as NotePad++, you can use 'OpenFold' and 'CloseFold' to collapse sections. This feature doesn't add anything new to the guide, but makes it easier to edit. Image as example:
notepad++_4nDcLYCtU5

@plasticmacaroni
Copy link
Owner

I've given this a lot of thought as I've tested it over the past couple weeks! How would you feel about a second "development" branch with the tags included? I'm afraid that contributors might not understand the HTML comments if they use different editors, and might feel like they need to maintain or update them alongside new sections. In the end, it's up to you, as honestly you've done so much for this guide.

@plasticmacaroni
Copy link
Owner

(To double-post, either way, all of the previous commits look incredible. That's the only one that's giving me pause.)

@asmoranomar
Copy link
Contributor Author

Unfortunately I still haven't been able to load any of my saves since the patch and hotfixes dropped. I have hundreds of them for playtesting and I really do not feel like playing through the game again to get them all back. Hopefully a future hotfix solves the problem.

This is all to say that, at the moment, I can't make any sweeping changes to the guide. Since it was a feature I only used for myself, I see no reason why it should remain if I'm not actively contributing. We can discuss adding it back in at a later date.

I'll make the changes soon.

@plasticmacaroni plasticmacaroni merged commit 9fbd690 into plasticmacaroni:main Mar 11, 2024
@plasticmacaroni
Copy link
Owner

Merged. If you'd like to create the edits into an alternate dev branch, I'm happy to do so. I'm so sorry your saves are not working at all :(

After researching it it seems that a lot of folks are dealing with this issue in the newest patch :(

@plasticmacaroni
Copy link
Owner

Until you get things working, I updated the shoutout section of the main Readme page:
https://github.com/plasticmacaroni/bg3-missables/blob/main/README.md#biggest-contributor-shoutout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants