Enum translations #442
Merged
Enum translations #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In display text and also interactive select options
difernandez
force-pushed
the
enum-translations
branch
3 times, most recently
from
fae4493
to
09ff1ac
Compare
ldlsegovia
approved these changes
Feb 16, 2023
| eq('Archivado, ya no se considera') | ||
| ) | ||
| expect(page.find("#{option_selector}[value='42']").text).to eq('Estado que no existe') | ||
| end |
There was a problem hiding this comment.
Maybe it would be good to test that the collection is actually filtered, what do you think? maybe it's not necessary
There was a problem hiding this comment.
I agree, especially considering that the filter only works with the db value, that way we make sure it's working. I'll add the test soon before merging
difernandez
force-pushed
the
enum-translations
branch
2 times, most recently
from
e5ee82e
to
e3f660b
Compare
Was used in paperclip validations, and due to the following bug it is missing from ruby 3.1 image: CircleCI-Public/cimg-ruby#106
difernandez
force-pushed
the
enum-translations
branch
from
e3f660b
to
f2745bc
Compare
|
@ldlsegovia requested re-review, as I had to include a fix elsewhere for the new tests to pass: default_select setting in |
ldlsegovia
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds enum translation support in tag column and rows, as well as in select input filters. Translation is already supported in formtastic, but this only works for inputs in a form for the model object, when used in filters the object is a Ransack object, and the translation didn't work the same. Changes include:
EnumUtilswith tanslation related methods. Theoptions_for_selectmethod allows for the enum option name or the value in database to be used. This is because the AA filter must use the database value, while the interactivetag_columnmust use the nameActiveAdmin::Inputs::Filters::SelectInputto allow translation when using with an enum and not includingcollectionoptionPlus, last three commits include circleci and test suite related fixes.
Question for the reviewer: I'm not sure I put the code of the filter extension where it should be. As it was an extension, I put it in the
/supportfolder, following the example of theRansackFormBuilderExtension. And given that it is changing behavior of an input filter, I put a test for this inspec/features/inputs. Let me know if you would change any of this