Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AndroidInAppWebViewOption for using Hybrid Composition #1

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Add AndroidInAppWebViewOption for using Hybrid Composition #1

merged 2 commits into from
Aug 24, 2020

Conversation

tneotia
Copy link

@tneotia tneotia commented Aug 24, 2020

Connection with issue(s)

Add the ability to dynamically enable/disable Hybrid Composition by means of an AndroidInAppWebViewOption.

Testing and Review Notes

Steps:

  • Flutter version v1.20+.
  • Set useHybridComposition to true in example/lib/in_app_webview_example.screen.dart (at line 92 add):
android: AndroidInAppWebViewOptions(
    useHybridComposition: true,
)
  • Install Google gboard input method, and install chinese pinyin or chuyin input method, and launch InAppWebView with some website that needs some input.
  • Focus on the text field and see if it's possible to switch to pinyin input method in gboard (should be possible).
  • Set useHybridComposition to false in example/lib/in_app_webview_example.screen.dart.
  • Focus on the text field and see if it's possible to switch to pinyin input method in gboard (should not be possible).

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@tneotia
Copy link
Author

tneotia commented Aug 24, 2020

@plateaukao Don't know how it works if I would like this commit to get merged onto the branch you pushed to flutter_inappwebview, but I tried it anyways. Let me know if there is a different way I should do this.

Copy link
Owner

@plateaukao plateaukao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@plateaukao plateaukao merged commit 0db8d13 into plateaukao:support_hybrid_composition_in_android Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants