Move Default Auto-Correct Misspellings to Separate File #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… custom auto-correct and default auto-correct files be loaded when the rule is enabled or on layout ready if the rule is enabled
…kept and updated a comment
pjkaufman
added
enhancement
44 tasks
|
I need to update where it is pointing for the default misspellings list on the settings page, but after that this should be clear to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a push to make plugins more performant for the Obsidian app. The
main.jsfor the Linter is about 1.4MB in size. Most of the bundled size (.9MB) comes from the default misspellings. However this is really only needed if auto-correct common misspellings is enabled. I suspect that not all users are using this rule, but it is causing the bundle to be so large that it is slowing down the load time of the plugin which thus impacts the load time of the user's vault. To help speed this up, it is being moved to its own Markdown file. This Markdown file should be installed once when the rule is enabled or if it is missing. This also allows for the auto-correct file to be loaded when the layout is ready. This also greatly helps improve the loading time of the plugin.The zip file generated as part of release should now include the default Markdown file to help manual installations work well.