Hide Unreachable Settings #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than the enabled toggle when the rule enable/parent setting is disabled
…itself so the hiding of the value makes more sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1187
This year it was shown how we can hide settings that are dependent on one another in plugins. So I decided I could do this in the Linter, as such I took a stab at it. There may be some wonkiness with search since searching for rules will still bring up rules that have hidden settings even if their displayed settings do not have the text that is being searched on. This change will also hopefully make things easier for new users to navigate the settings since unreachable settings should be hidden.
There may be a couple of general settings that can still benefit from being disabled based on the Linter rules they depend on. I am mostly thinking about lint on file content change.