Make CE HTTPS use current Mozilla recommendations #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Sep 11, 2024
| https_opts = [ | ||
| port: https_port, | ||
| ip: listen_ip, | ||
| cipher_suite: :compatible, |
There was a problem hiding this comment.
Plug's compatible cipher suite is a bit outdated: elixir-plug/plug#1143
ruslandoga
changed the title
ruslandoga
changed the title
ruslandoga
commented
Sep 11, 2024
config/runtime.exs
Outdated
| transport_options: [socket_opts: [log_level: :warning]] | ||
| ] | ||
| # the following configuration is based on https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28recommended.29 | ||
| # except we make the server choose the cipher preference |
There was a problem hiding this comment.
Because that's what https://plausible.io (or rather Bunny CDN) is doing.
ruslandoga
changed the title
ruslandoga
changed the title
ruslandoga
commented
Sep 11, 2024
config/runtime.exs
Outdated
| ~c"TLS_CHACHA20_POLY1305_SHA256", | ||
| # Mozilla recommended cipher suites (TLS 1.2) | ||
| ~c"ECDHE-ECDSA-AES128-GCM-SHA256", | ||
| ~c"ECDHE-RSA-AES128-GCM-SHA256", |
There was a problem hiding this comment.
RSA ones can be removed since certbot generates ECDSA keys by default, and we (and site_encrypt) don't provide any options to configure it.
zoldar
approved these changes
Sep 12, 2024
cnkk
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR continues #4491 and makes CE HTTPS follow Mozilla recommendations for "Intermediate" compatibility.
ChatGPT says this configuration suite would cover approximately 95-98% of global web clients.
It also excludes iPhones with iOS 8 and below.
Compared to Plug's
compatiblesuite (used in #4491), this configuration:Current SSL Labs results: https://www.ssllabs.com/ssltest/analyze.html?d=who.copycat.fun
Compared to Plausible Cloud, this configuration: