Fix text encoding in glTF exporter (#7034)

playcanvas · Oct 15, 2024 · 9829e16 · 9829e16
1 parent 79800b4
commit 9829e16
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/extras/exporters/gltf-exporter.js b/src/extras/exporters/gltf-exporter.js
@@ -769,13 +769,13 @@ class GltfExporter extends CoreExporter {
         const resources = this.collectResources(entity);
 
         return this.buildJson(resources, options).then((json) => {
-
-            const jsonText = JSON.stringify(json);
+            const encoder = new TextEncoder();
+            const jsonData = encoder.encode(JSON.stringify(json));
 
             const headerLength = 12;
 
             const jsonHeaderLength = 8;
-            const jsonDataLength = jsonText.length;
+            const jsonDataLength = jsonData.length;
             const jsonPaddingLength = (4 - (jsonDataLength & 3)) & 3;
 
             const binaryHeaderLength = 8;
@@ -804,9 +804,7 @@ class GltfExporter extends CoreExporter {
             let offset = headerLength + jsonHeaderLength;
 
             // JSON data
-            for (let i = 0; i < jsonDataLength; i++) {
-                glbView.setUint8(offset + i, jsonText.charCodeAt(i));
-            }
+            new Uint8Array(glbBuffer, offset, jsonDataLength).set(jsonData);
 
             offset += jsonDataLength;